feat: add catalog UI to browse the catalog #68
Conversation
benoitf
requested review from
dgolovin,
jeffmaury and
SoniaSandler
and removed request for
a team
|
I am not sure to follow, is this going to be iframed in the website ? |
yes, to reuse most of UI svelte components |
|
how it renders within the website: Screen.Recording.2024-10-21.at.11.45.56.mov |
it's to have the current content of the website https://github.com/containers/podman-desktop-catalog/tree/gh-pages/api at the proper location |
There was a problem hiding this comment.
Remarks:
- UI is quite rude, maybe worth adding a header ?
- Seems to be some components are duplicated, maybe follow up PR to get rid of it
- this PR holds a copy of the catalog so is it temporary
- When we list extension versions maybe worth having a link to install that specific version
- Validating workflow missing, follow up PR ?
.gitignore
Outdated
| /.svelte-kit | ||
| /.eslintcache | ||
| /coverage | ||
| /package |
src/app.html
Outdated
| <link rel="icon" href="%sveltekit.assets%/favicon.png" /> | ||
| <meta name="viewport" content="width=device-width" /> | ||
| %sveltekit.head% | ||
| </head> |
| } | ||
|
|
||
| test('check initial light theme', async () => { | ||
| const { baseElement } = render(Appearance, {}); |
There was a problem hiding this comment.
| const { baseElement } = render(Appearance, {}); | |
| const { baseElement } = render(Appearance); |
| } | ||
| </script> | ||
|
|
||
| <button |
There was a problem hiding this comment.
so here it's using button to say that we have an active element with a onclick trigger (a card) but it doesn't look at all as a button
src/routes/page.svelte.spec.ts
Outdated
| import { catalogExtensions } from '$lib/extensions.svelte'; | ||
|
|
||
| import catalogOfExtensions from '../../static/api/extensions.json'; | ||
| import Page from '././+page.svelte'; |
There was a problem hiding this comment.
| import Page from '././+page.svelte'; | |
| import Page from './+page.svelte'; |
You'll will see it through podman desktop website |
what are the components duplicated ? |
it's not, it's how the files will be served (you won't need to create a PR to the gh-pages branch, it will be against this folder) |
you don't have the ability to install a specific version (no link possible for the moment) |
yes here I was waiting on how to proceed to merge such a big PR, I will split with chunks |
|
This is looking great as a first step, I think we can move forward with this and create follow-up issues for improving the experience and the UI accordingly with the mockups on the points mentioned before. |
|
first batch: #69 (setup of the project) I've included GH action |
benoitf
force-pushed
the
DESKTOP-8972
branch
2 times, most recently
from
fcbf16d to
898f9a4
Compare
related to podman-desktop/podman-desktop#8972 Signed-off-by: Florent Benoit <[email protected]> Change-Id: I9e121490ccf65275ec1273f716d9d7a8e26d791a
|
replaced by #72 |
related to podman-desktop/podman-desktop#8972
Screen.Recording.2024-10-21.at.11.33.25.mov
Change-Id: I820ba559ae561308bca38dc867439615d6e8d8af